Add PeriodicReportingFetchV2Error to fetch metrics multiple times #40251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CloudWatch metrics can take time to appear after a we create a brand new resource.
botelastic
bot
added
the
needs_team
|
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
zmoog
added
the
Team:obs-ds-hosted-services
botelastic
bot
removed
the
needs_team
zmoog
force-pushed
the
zmoog/aws-metrics-flacky-tests
branch
from
c887f60
to
5b39dc1
Compare
|
/test |
3 similar comments
|
/test |
|
/test |
|
/test |
zmoog
changed the title
|
Pinging @elastic/obs-ds-hosted-services (Team:obs-ds-hosted-services) |
pierrehilbert
added
the
Team:Elastic-Agent-Data-Plane
|
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
pierrehilbert
requested review from
faec and
VihasMakwana
and removed request for
AndersonQ and
belimawr
| @@ -20,7 +21,7 @@ func TestFetch(t *testing.T) { | |||
| config := mtest.GetConfigForTest(t, "sqs", "300s") | |||
|
|
|||
| metricSet := mbtest.NewReportingMetricSetV2Error(t, config) | |||
| events, errs := mbtest.ReportingFetchV2Error(metricSet) | |||
| events, errs := mbtest.PeriodicReportingFetchV2Error(metricSet, 1*time.Minute, 8*time.Minute) | |||
There was a problem hiding this comment.
Are we planning on replacing ReportingfetchV2Error with PeriodicReportingFetchV2Error in other metricsets?
There was a problem hiding this comment.
I want to focus this PR on removing the flakiness from the test suite so that other teams can continue with their tasks.
Do you know of other tests that need more than one call to Fetch() to succeed due to latency or something similar?
There was a problem hiding this comment.
But if this solution proves effective, we can adopt it for more tests that need more than one fetch.
kaiyan-sheng
approved these changes
Jul 16, 2024
tetianakravchenko
approved these changes
Jul 17, 2024
faec
approved these changes
Jul 17, 2024
|
@zmoog should we backport this to 8.15/8.14/7.17 ? |
Good point. Let me add the labels and take care of these backports. |
zmoog
added
backport-7.17
mergify bot
pushed a commit
that referenced
this pull request
Jul 18, 2024
…0251) * Retry fetching CloudWatch metrics a few times CloudWatch metrics can take time to appear after a we create a brand new resource. * fix wrong import * Fix events * Retry 5 times every 60s * Switch to PeriodicReportingFetchV2Error * Fix linter complaints * Remove unused code * Remove unused code * Address linter complaints * Address linter complaints * Improve function docs * Cleanup (cherry picked from commit 532133b)
mergify bot
pushed a commit
that referenced
this pull request
Jul 18, 2024
…0251) * Retry fetching CloudWatch metrics a few times CloudWatch metrics can take time to appear after a we create a brand new resource. * fix wrong import * Fix events * Retry 5 times every 60s * Switch to PeriodicReportingFetchV2Error * Fix linter complaints * Remove unused code * Remove unused code * Address linter complaints * Address linter complaints * Improve function docs * Cleanup (cherry picked from commit 532133b)
mergify bot
pushed a commit
that referenced
this pull request
Jul 18, 2024
…0251) * Retry fetching CloudWatch metrics a few times CloudWatch metrics can take time to appear after a we create a brand new resource. * fix wrong import * Fix events * Retry 5 times every 60s * Switch to PeriodicReportingFetchV2Error * Fix linter complaints * Remove unused code * Remove unused code * Address linter complaints * Address linter complaints * Improve function docs * Cleanup (cherry picked from commit 532133b) # Conflicts: # metricbeat/mb/testing/modules.go
This was referenced Jul 18, 2024
Merged
Merged
zmoog
added a commit
that referenced
this pull request
Jul 18, 2024
…trics multiple times (#40295) * Add PeriodicReportingFetchV2Error to fetch metrics multiple times (#40251) * Retry fetching CloudWatch metrics a few times CloudWatch metrics can take time to appear after a we create a brand new resource. * fix wrong import * Fix events * Retry 5 times every 60s * Switch to PeriodicReportingFetchV2Error * Fix linter complaints * Remove unused code * Remove unused code * Address linter complaints * Address linter complaints * Improve function docs * Cleanup (cherry picked from commit 532133b) # Conflicts: # metricbeat/mb/testing/modules.go * Resolve conflicts --------- Co-authored-by: Maurizio Branca <[email protected]> Co-authored-by: Maurizio Branca <[email protected]>
zmoog
added a commit
that referenced
this pull request
Jul 18, 2024
…0251) (#40296) * Retry fetching CloudWatch metrics a few times CloudWatch metrics can take time to appear after a we create a brand new resource. * fix wrong import * Fix events * Retry 5 times every 60s * Switch to PeriodicReportingFetchV2Error * Fix linter complaints * Remove unused code * Remove unused code * Address linter complaints * Address linter complaints * Improve function docs * Cleanup (cherry picked from commit 532133b) Co-authored-by: Maurizio Branca <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Try to fetch CloudWatch metrics multiple times instead of just once.
CloudWatch metrics can take time to appear after creating a brand-new resource. So, the tests must fetch the metrics multiple times until they find the metric values or reach the time limit.
Checklist
I have made corresponding changes to the documentationI have made corresponding change to the default configuration filesI have added an entry inCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Related issues